Big update #66
Merged
Big update #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meagonqz
reviewed
Mar 29, 2017
| @@ -1,4 +1,4 @@ | |||
| module Humidifier | |||
| # Gem version | |||
| VERSION = '1.0.6'.freeze | |||
| VERSION = '1.2.1'.freeze | |||
There was a problem hiding this comment.
To stay in line with the AWS CloudFormation resource specification version (so people know which version is which)
|
What's the process now for updating the docs? Are they still hosted by github on |
|
They'll still be hosted by github pages, but it's just going to be off the master branch |
meagonqz
reviewed
Mar 29, 2017
| @@ -8,7 +8,7 @@ Humidifier allows you to build AWS CloudFormation (CFN) templates programmatical | |||
|
|
|||
| For the full docs, go to [https://localytics.github.io/humidifier/](http://localytics.github.io/humidifier/). For local development instructions, see the [Development](https://localytics.github.io/humidifier/#label-Development) section. | |||
There was a problem hiding this comment.
It looks like the Development instructions need to be updated to specify Ruby 2.1 as well if they aren't already (big PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things. It:
docsdirectory. This greatly simplifies our docs workflow and will hopefully ensure that they always get updated.Utils::enumerable_to_hmethod which was needed to backport theto_hmethod to ruby 2.0.