New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish `geotrellis.spark.TestEnvironment` #2012

Closed
metasim opened this Issue Feb 13, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@metasim
Member

metasim commented Feb 13, 2017

When doing Spark tests in my own code it would be nice to use the same test environment setup that GeoTrellis uses for Spark, as defined by geotrellis.spark.TestEnvironment. There are at least two ways to do this:

  1. Publish the "org.locationtech.geotrellis" %% "geotrellis-spark" % "1.0.0" % "test" artifact as a part of the standard release process. This should be as easy as adding publishArtifact in (Test, packageBin) := true to the sub-project.
  2. Refactor geotrellis.spark.TestEnvironment so that it can live in geotrellis-spark-testkit, which does get published (I think).
@metasim

This comment has been minimized.

Member

metasim commented Feb 13, 2017

Happy to work on this if you tell me which direction you'd like me to take.

@lossyrob

This comment has been minimized.

Member

lossyrob commented Feb 13, 2017

Quick answer, IMO it should be in spark-testkit, that's were we publish generic test code for usage in other projects.

@pomadchin pomadchin self-assigned this Feb 22, 2017

pomadchin added a commit to pomadchin/geotrellis that referenced this issue Feb 22, 2017

fix locationtech#2012
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>

pomadchin added a commit to pomadchin/geotrellis that referenced this issue Feb 22, 2017

fixes locationtech#2012
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>

pomadchin added a commit to pomadchin/geotrellis that referenced this issue Feb 22, 2017

move TestEnvironment into spark-testkit; fixes locationtech#2012
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
@metasim

This comment has been minimized.

Member

metasim commented Feb 25, 2017

@pomadchin Thanks much for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment