New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch direction of symlinks in top level of repo #2428

Closed
lossyrob opened this Issue Oct 13, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@lossyrob
Member

lossyrob commented Oct 13, 2017

I thought that symlinking the CHANGELOG and CONTRIBUTING docs to the top level will increase visibility. However, GitHub doesn't render the documents that are symlinked. We should switch the direction of the symlink so the actual file lives in the top level, and the docs/ versions are the links.

@jamesmcclain

This comment has been minimized.

Show comment
Hide comment
@jamesmcclain

jamesmcclain Oct 23, 2017

Member

Resolved by #2447

Member

jamesmcclain commented Oct 23, 2017

Resolved by #2447

@rossbernet rossbernet referenced this issue Oct 27, 2017

Merged

Sprucing the 1.2 Changelog #2457

4 of 4 tasks complete
@fosskers

This comment has been minimized.

Show comment
Hide comment
@fosskers

fosskers Oct 27, 2017

Contributor

Switching the direction of the symlinks breaks docs building. As an alternative I propose huge links (possibly badges) at the top of our README for the CHANGELOG and CONTRIBUTING doc.

This is being addressed in #2457 .

Contributor

fosskers commented Oct 27, 2017

Switching the direction of the symlinks breaks docs building. As an alternative I propose huge links (possibly badges) at the top of our README for the CHANGELOG and CONTRIBUTING doc.

This is being addressed in #2457 .

@echeipesh

This comment has been minimized.

Show comment
Hide comment
@echeipesh

echeipesh Oct 31, 2017

Contributor

The button and the spruced up CHANGELOG are both awesome, considering the spirit of this resolved.

Contributor

echeipesh commented Oct 31, 2017

The button and the spruced up CHANGELOG are both awesome, considering the spirit of this resolved.

@echeipesh echeipesh closed this Oct 31, 2017

@lossyrob lossyrob modified the milestones: 1.3, 1.2 Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment