New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polygonal Summary] Relax types to anything `Tile`d #1611

Merged
merged 2 commits into from Aug 17, 2016

Conversation

Projects
None yet
3 participants
@fosskers
Contributor

fosskers commented Aug 15, 2016

TODO

  • Relax constraints
  • Tests

Motivation

Previously, the abstact class PolygonalSummaryTileLayerRDDMethods required a TileLayerRDD, which has certain constraints on what its metadata must contain. This was restrictive, as the polygonalSummary methods only require RDDs whose internals can be converted to Rasters. This PR relaxes the type requirements, such that anything that can convert to Rasters can use these summary methods automatically.

fosskers added some commits Aug 15, 2016

@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Aug 16, 2016

Tests are checked off but there is no changes in test files, missing commit ?

@fosskers

This comment has been minimized.

Contributor

fosskers commented Aug 17, 2016

Nope, that just indicates that the tests still pass. I didn't write anything new.

@echeipesh echeipesh merged commit dbcf5f4 into locationtech:master Aug 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lossyrob lossyrob added this to the 0.10.3 milestone Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment