New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in merge logic. #1793

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
2 participants
@lossyrob
Member

lossyrob commented Nov 11, 2016

There was a bug which took effect when we used the extent-based merge methods on cell types that had no NoData handling. This is caused by the interpolation returning NoData values when we interpolate outside the bounds of the original tile, so was happening when we were interpolating values of a larger raster with the values of a smaller one (e.g. during tileToLayout and Pyramiding)

@lossyrob lossyrob added this to the 1.0 milestone Nov 12, 2016

@jamesmcclain

This comment has been minimized.

Show comment
Hide comment
@jamesmcclain

jamesmcclain Nov 14, 2016

Member

It looks as though the intent is to treat the value zero as neutral for purposes of merging using raw cell types? I can detect no problems: all raw types are accounted for on lines 103 and 118 of SinglebandTileMergeMethods.scala and there are no non-raw types there; the logic itself appears to be correct.

Member

jamesmcclain commented Nov 14, 2016

It looks as though the intent is to treat the value zero as neutral for purposes of merging using raw cell types? I can detect no problems: all raw types are accounted for on lines 103 and 118 of SinglebandTileMergeMethods.scala and there are no non-raw types there; the logic itself appears to be correct.

@lossyrob

This comment has been minimized.

Show comment
Hide comment
@lossyrob

lossyrob Nov 14, 2016

Member

@jamesmcclain yes. I'll take that as approval? You can go to the "Files changed" tab, "Review Changes" and then "Approve" if so. Thankya

Member

lossyrob commented Nov 14, 2016

@jamesmcclain yes. I'll take that as approval? You can go to the "Files changed" tab, "Review Changes" and then "Approve" if so. Thankya

@jamesmcclain

This comment has been minimized.

Show comment
Hide comment
@jamesmcclain

jamesmcclain Nov 14, 2016

Member

I approve!

Member

jamesmcclain commented Nov 14, 2016

I approve!

@lossyrob lossyrob merged commit 1ddfa98 into locationtech:master Nov 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment