New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Non-Point Pixel + Partial Cell Rasterizer Bug #1804

Merged
merged 3 commits into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@jamesmcclain
Member

jamesmcclain commented Nov 14, 2016

The issue was that when there were edges which crossed a pixel but whose intersection with the scan rectangle was outside of that pixel, the pixel was not being reported.

Supersedes #1800
Connects #1801

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Nov 14, 2016

@zaikin Thanks for the bug report. These changes fix the broken test that you provided. Would you mind testing these changes to see if they fix your original issue?

@zaikin

This comment has been minimized.

Contributor

zaikin commented Nov 14, 2016

@jamesmcclain yes, it works. Thx 🎉

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Nov 14, 2016

Sounds great. Thanks again for the bug report!

@lossyrob

This comment has been minimized.

Member

lossyrob commented Nov 14, 2016

@zaikin in order for us to use the commit with the unit tests, we'd need you to sign a CLA (as described in our contributing.md), and re-do that commit with an email that is associated with your github account. Would you be able to do these couple of things? Sorry for the hassle, and thanks for the bug report and contribution!

Also, on mending the commit, if you could "sign" the commit (option -s), that would be ideal.

@zaikin

This comment has been minimized.

Contributor

zaikin commented Nov 15, 2016

@lossyrob no problem, i'll do it a bit later today.

@lossyrob

This comment has been minimized.

Member

lossyrob commented Nov 15, 2016

@zaikin thanks! I'm looking to push an RC out today, so if you all that done today, I'll be able to include it in the RC.

Add more tests
Signed-off-by: Alexandr Zaikin <alexandr@zaik.in>
@zaikin

This comment has been minimized.

Contributor

zaikin commented Nov 15, 2016

@lossyrob i redid commit and sent a signed CLA.

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Nov 15, 2016

Rebasing now.

jamesmcclain added some commits Nov 14, 2016

Fix Non-Point Pixel + Partial Cell Rasterizer Bug
The issue was that when there were edges which crossed a pixel but whose
intersection with the scan rectangle was outside of that pixel, the
pixel was not being reported.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:fix/rasterizer branch from 9ff5c7c to f6a6752 Nov 15, 2016

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Nov 15, 2016

Rebased.

@lossyrob

This comment has been minimized.

Member

lossyrob commented Nov 15, 2016

@zaikin many thanks!

+1 after travis

@lossyrob lossyrob added this to the 1.0 milestone Nov 15, 2016

@lossyrob lossyrob merged commit 849d321 into locationtech:master Nov 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lossyrob lossyrob removed the in progress label Nov 15, 2016

@jamesmcclain jamesmcclain deleted the jamesmcclain:fix/rasterizer branch Nov 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment