New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Polygon Rasterizer Issues #1963

Merged
merged 5 commits into from Jan 26, 2017

Conversation

Projects
None yet
3 participants
@jamesmcclain
Member

jamesmcclain commented Jan 15, 2017

Still Needs

  • Proper handling of horizontal segments for point-pixels
  • More test cases
  • Solidification
  • Feedback from gentleman who reported bug?

Fixes #1962

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:fix/polygon-rasterizer branch from 5654af1 to 22e3936 Jan 15, 2017

jamesmcclain added some commits Jan 15, 2017

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:fix/polygon-rasterizer branch from 22e3936 to 0550238 Jan 17, 2017

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Jan 17, 2017

@quertenmont This is not completely finished, but it may be complete enough to consider testing. The polygons that you sent should work now. This should be complete.

@jamesmcclain jamesmcclain changed the title from [WIP] Address Polygon Rasterizer Issues to Address Polygon Rasterizer Issues Jan 18, 2017

@quertenmont

This comment has been minimized.

quertenmont commented Jan 18, 2017

I'll try to give it a try in the coming days,
Thanks for your fast fix!

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Jan 18, 2017

You are welcome, sir. Thank you for the bug report and test cases!

@lossyrob lossyrob merged commit ca31aa0 into locationtech:master Jan 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@jamesmcclain jamesmcclain deleted the jamesmcclain:fix/polygon-rasterizer branch Jan 26, 2017

@lossyrob lossyrob added this to the 1.1 milestone Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment