New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro Schema Creation for ProjectedExtent and TemporalProjectedExtent #1971

Merged
merged 9 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@jbouffard
Contributor

jbouffard commented Jan 18, 2017

This PR adds two new codecs that can be encode/decoded in GeoTrellis: ProjectedExtent and TemporalProjectedExtent. The main reason for adding these two codecs is to allow for backend support between GeoTrellis and GeoPySpark.

jbouffard added some commits Jan 18, 2017

Added new types to ExtentCodecs
Signed-off-by: jbouffard <jbouffard@azavea.com>
Removed ProjectedExent and TemporalProjectedExtent from ExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>
Created ProjectedExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>
Created TemporalProjectedExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>
Added the new codecs to Implicits
Signed-off-by: jbouffard <jbouffard@azavea.com>
Added tests for the various ExtentCodecs
Signed-off-by: jbouffard <jbouffard@azavea.com>
Edited namespace in ProjectedExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>
Reversed code change in ExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>
Removed extra white space in ExtentCodec
Signed-off-by: jbouffard <jbouffard@azavea.com>

@jbouffard jbouffard changed the title from Avro Schema Creation for `ProjectedExtent` and `TemporalProjectedExtent` to Avro Schema Creation for ProjectedExtent and TemporalProjectedExtent Jan 18, 2017

@jbouffard

This comment has been minimized.

Contributor

jbouffard commented Jan 18, 2017

@lossyrob This is ready for review.

@lossyrob lossyrob merged commit 3bafc3f into locationtech:master Jan 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
.record("ProjectedExtent").namespace("geotrellis.vector")
.fields()
.name("extent").`type`(extentCodec.schema).noDefault()
.name("epsg").`type`().intType().noDefault()

This comment has been minimized.

@lossyrob

lossyrob Jan 23, 2017

Member

Can you update to use the proj4 string.
Or, if possible, check if it's an EPSG code, and then fall back to CRS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment