New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorTile: Use latest ScalaPB #2038

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
4 participants
@fosskers
Contributor

fosskers commented Mar 1, 2017

Bumping the dep wasn't enough, the IO code had to be regenerated as well.

Note: The generated code, while marked DO NOT EDIT!, has to be edited to include the license headers and the correct package name, namely geotrellis.vectortile.protobuf.internal.vector_tile.

@fosskers fosskers referenced this pull request Mar 1, 2017

Closed

Remove `vectortile` from Core GeoTrellis #2009

3 of 3 tasks complete

@lossyrob lossyrob merged commit aa60132 into master Mar 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lossyrob lossyrob removed the in progress label Mar 2, 2017

@fosskers fosskers deleted the fix/cgw/scalapb branch Mar 2, 2017

@lossyrob lossyrob added this to the 1.1 milestone Mar 12, 2017

@lossyrob lossyrob added the api change label Mar 12, 2017

@echeipesh

This comment has been minimized.

Show comment
Hide comment
@echeipesh

echeipesh Mar 13, 2017

Contributor

This change to generated code seemed to have been handled safely for minor release

Contributor

echeipesh commented Mar 13, 2017

This change to generated code seemed to have been handled safely for minor release

@fosskers

This comment has been minimized.

Show comment
Hide comment
@fosskers

fosskers Mar 13, 2017

Contributor

Also, the autogenerated code lives in an *.internal package, which by definition is never user facing and so avoids SemVer issues.

Contributor

fosskers commented Mar 13, 2017

Also, the autogenerated code lives in an *.internal package, which by definition is never user facing and so avoids SemVer issues.

@lossyrob lossyrob removed the api change label Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment