New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid malformed XML in S3 layer deletion #2040

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
@moradology
Contributor

moradology commented Mar 2, 2017

During failed ingests, metadata will often be written out despite no data having been written for the layer that metadata specifies. The trace such an attempted deletion causes: Exception in thread "main" com.amazonaws.services.s3.model.AmazonS3Exception: The XML you provided was not well-formed or did not validate against our published schema.

By ensuring that S3 deletion requests are only generated for non-empty listings, we avoid this Exception.

Only attempt deletion when s3 listing is non-empty
During failed ingests, metadata will often be written out despite no
data having been written for the layer that metadata specifies. By
ensuring that S3 deletion requests are only generated for non-empty
listings, we can avoid this Exception.

@moradology moradology changed the title from Only attempt deletion when s3 listing is non-empty to Avoid malformed XML in S3 layer deletion Mar 2, 2017

@lossyrob lossyrob added this to the 1.0.1 milestone Mar 2, 2017

@echeipesh echeipesh merged commit a125036 into locationtech:master Mar 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lossyrob lossyrob modified the milestones: 1.1, 1.0.1 Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment