New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3InputFormat - bucket names support period and dashes #2133

Merged
merged 2 commits into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@ehochmuth
Contributor

ehochmuth commented Apr 9, 2017

Fixes #2133

@ehochmuth

This comment has been minimized.

Contributor

ehochmuth commented Apr 9, 2017

Just noticed ConfigFormats in spark-etl has the same problem. One option would be to change these to use http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/AmazonS3URI.html
however i don't think this supports embedding the aws key in the uri.

@lossyrob lossyrob added this to the 1.1 milestone Apr 9, 2017

@lossyrob

This comment has been minimized.

Member

lossyrob commented Apr 11, 2017

Thanks for the contribution! Appreciate the consideration about alternate solutions, but I think the approach you took is the most simple and sound.

Can you sign a Eclipse Committer Agreement? The instructions to do so are here: http://geotrellis.readthedocs.io/en/latest/contributing.html#eclipse-contributor-agreement-eca.

Let me know if you have any questions!

@ehochmuth

This comment has been minimized.

Contributor

ehochmuth commented Apr 11, 2017

@lossyrob

This comment has been minimized.

Member

lossyrob commented Apr 11, 2017

No, the validation is being strange so it is failing everyone.

The other thing that's a bit more annoying is that Eclipse needs contributors to do a "sign-off" on the commits; it's described second paragraph here: http://geotrellis.readthedocs.io/en/latest/contributing.html#pull-requests.

Can you add the sign offs on the commits? After that I'm 👍 to merge

@ehochmuth ehochmuth force-pushed the ehochmuth:master branch from f43f3e3 to f5d2940 Apr 11, 2017

@ehochmuth

This comment has been minimized.

Contributor

ehochmuth commented Apr 11, 2017

@pomadchin

This comment has been minimized.

Member

pomadchin commented Apr 11, 2017

@ehochmuth oh; sign off means sign off header, like in this commit. It can be achieved by using -s flag: git commit -s -m "msg".

ehochmuth added some commits Apr 9, 2017

Author: Erich Hochmuth
Signed-off-by: Erich Hochmuth <ehochmuth@climate.com>
Author: Erich Hochmuth
Signed-off-by: Erich Hochmuth <ehochmuth@climate.com>

@ehochmuth ehochmuth force-pushed the ehochmuth:master branch from f5d2940 to a68531a Apr 11, 2017

@ehochmuth

This comment has been minimized.

Contributor

ehochmuth commented Apr 11, 2017

@lossyrob

This comment has been minimized.

Member

lossyrob commented Apr 11, 2017

Perfect, thank you!

@lossyrob lossyrob merged commit cf8ad04 into locationtech:master Apr 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment