New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized handling of `CellType.name` #2142

Merged
merged 3 commits into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@metasim
Member

metasim commented Apr 18, 2017

to make it the authoritative representation of cell type, over toString.
Moved name resolution to companion object to make it symmetric with fromName implementation.

In the previous implementation, inheritance was used as the means of having different values of name per type. That caused problems when trying to come up with a general solution based on calling super to generate derivatives, since self-types were used over direct inheritance. Having the to/from name handling in the companion also keeps coupled implementations closer to each other.

cc: @moradology

Signed-off-by: Simeon H.K. fitch fitch@astraea.io

metasim added some commits Apr 18, 2017

Reoganized handling of `CellType.name`
to make it the authoritave representation of cell type, over `toString`.
Moved `name` resolution to companion object to make it symmetric with `fromName` implementation.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Added test to confirm previous `toString`/`fromString` behavior.
Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
@lossyrob

+1 after deprecation string update

* @param name A string representing a cell type, as reported by [[DataType.name]] e.g. "uint32"
* @return The CellType corresponding to `name`
*/
@deprecated("Use `fromName` instead", "1.2.0")

This comment has been minimized.

@lossyrob

lossyrob Apr 19, 2017

Member

Can you change to 1.1.0?

@lossyrob lossyrob added this to the 1.1 milestone Apr 19, 2017

@lossyrob lossyrob merged commit bd30bec into locationtech:master Apr 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@metasim metasim deleted the metasim:celltype-name branch Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment