New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a different Json Schema validator #2222

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
3 participants
@pomadchin
Member

pomadchin commented May 31, 2017

A lightweight https://github.com/networknt/json-schema-validator is used instead of https://github.com/java-json-tools/json-schema-validator.

Were applied some changes into the input schema definition (it was incorrect).
Some changes into printing validation error messages were added (logger used, error messages are red)

A source with tests for different json schema validators in different languages:
https://github.com/json-schema-org/JSON-Schema-Test-Suite

@pomadchin pomadchin requested a review from lossyrob May 31, 2017

@pomadchin pomadchin force-pushed the pomadchin:feature/json-validation branch from 41fc405 to f1f9b8b May 31, 2017

@pomadchin pomadchin removed the in progress label May 31, 2017

@pomadchin pomadchin force-pushed the pomadchin:feature/json-validation branch from f1f9b8b to a9ab63d May 31, 2017

Move to com.networknt Json Schema validator
Signed-off-by: Grisha Pomadchin <gr.pomadchin@gmail.com>

@pomadchin pomadchin force-pushed the pomadchin:feature/json-validation branch from a9ab63d to e732358 May 31, 2017

@lossyrob lossyrob added this to the 1.1 milestone Jun 1, 2017

@lossyrob

This comment has been minimized.

Member

lossyrob commented Jun 2, 2017

Dependency Additions

json-schema-validator-dependency-graph

CQs required for

Json Schema Validator

  • com.networknt:json-schema-validator:0.1.7

Jackson

  • com.fasterxml.jackson.core:jackson-annotations:2.8.0
  • com.fasterxml.jackson.core:jackson-core:2.8.7
  • com.fasterxml.jackson.core:jackson-databind:2.8.7

Question: Why is jackson-annotations at 2.8.0 for the 2.8.7 versions? Can we submit these three as a single CQ (do they share the same repository?)

Note there are approved CQs for jackson 1.5.0

Apache Commons Lang

  • org.apache.commons:commons-lang3:3.5

3.5 should be submitted, Apache commons-lang3 version 3.4 is already approved.

@lossyrob lossyrob added the needs-cq label Jun 2, 2017

@pomadchin

This comment has been minimized.

Member

pomadchin commented Jun 2, 2017

I decided to draw the whole project graph too using

./sbt spark-etl/dependencyGraphMl

Schema validator neighbours:

image

This information makes sense, as it corresponds to com.networknt:json-schema-validator:0.1.7 (approved, CQ 13652) pom.xml

But annotations version is a mystery.

image

Looks like it really should be 2.8.0 (probably their internal versions inconsistency): https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind/2.8.7

Requests should be sent in all cases (same version / different versions of these deps) separately:

org.apache.commons:commons-lang3:3.5 (approved, CQ 13653) neighbours:

image

At least opencsv depends on it too, request should be done too.

There is also org.apache.commons:commons-lang3:3.1 in deps:

image

But it's evicted by 3.5

Update: all deps are approved.

@echeipesh echeipesh added needs-cq and removed needs-cq labels Jun 2, 2017

@lossyrob

This comment has been minimized.

Member

lossyrob commented Jun 2, 2017

CQ's Approved. +1

@lossyrob lossyrob merged commit 936460f into locationtech:master Jun 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment