New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueReaderProvier #2286

Merged
merged 4 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@echeipesh
Contributor

echeipesh commented Jul 17, 2017

Closes: #2281

echeipesh added some commits Jul 17, 2017

@jpolchlo

There needs to be some mention of the fact that without a MergeStrategy.concat in the build.sbt of any project that uses the SPI functionality, the META-INF/services/ValueReaderProvider will be overwritten, and not all plugins will be registered. This may affect the build.sbt for spark-etl.

def valueReader(uri: URI, store: AttributeStore): ValueReader[LayerId] = {
val _uri = trim(uri)
val path = new Path(_uri)
val params = UriUtils.getParams(_uri)

This comment has been minimized.

@pomadchin

pomadchin Jul 27, 2017

Member

For valueReader, layerWriter, attribuetStore

val _uri = trim(uri)
val path = new Path(_uri)
val params = UriUtils.getParams(_uri)

Mb that can be sugared?

This comment has been minimized.

@echeipesh

echeipesh Jul 27, 2017

Contributor

Not really user functionality, so I wanted to leave it as bare bones as possible

@pomadchin

Looks fine, only one comment though

@echeipesh echeipesh merged commit 1f937c7 into locationtech:master Jul 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment