New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3GeoTiffRDD behavior with some options. #2317

Merged
merged 3 commits into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@pomadchin
Member

pomadchin commented Aug 6, 2017

Fixed incorrect S3GeoTiffRDD behavior when both partitionBytes & numPattition options set.
Fixes #2307

@pomadchin pomadchin requested a review from lossyrob Aug 6, 2017

options.numPartitions.foreach{ n => S3InputFormat.setPartitionCount(conf, n) }
options.partitionBytes.foreach{ n => S3InputFormat.setPartitionBytes(conf, n) }
options.numPartitions.foreach { n => S3InputFormat.setPartitionCount(conf, n) }
if(options.numPartitions.isEmpty) options.partitionBytes.foreach { n => S3InputFormat.setPartitionBytes(conf, n) }

This comment has been minimized.

@echeipesh

echeipesh Aug 6, 2017

Contributor

Worth a logger.warn about disregarding the partition bytes option.

@pomadchin pomadchin force-pushed the pomadchin:fix/s3if-conditions branch 2 times, most recently from 72da164 to 91e22a8 Aug 6, 2017

@pomadchin pomadchin force-pushed the pomadchin:fix/s3if-conditions branch from 91e22a8 to b354101 Aug 6, 2017

@jamesmcclain

This is not a full review, but I can confirm that this resolves the issue reported in #2307

@echeipesh echeipesh merged commit 8e9de3d into locationtech:master Aug 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@echeipesh echeipesh referenced this pull request Oct 31, 2017

Closed

Tile rasters by default #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment