New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requirement for `CRS` implementations to provide a readable `toString` representation. #2337

Merged
merged 3 commits into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@metasim
Member

metasim commented Aug 19, 2017

Added implementations for anonymous CRS implementations and singletons.

metasim added some commits Aug 19, 2017

Added requirement that `CRS` implementations provide a `show`
implementation to ensure that when `toString` is called you don't get
some illegible default `toString` implementation. This is necessary because
`CRS` is a trait that is implemented in many cases by anonomous classes.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Cruft removal (stray println).
Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
@metasim

This comment has been minimized.

Member

metasim commented Aug 19, 2017

I could see an argument for not requiring a show implementation (burden on possible third-party implementations). Let me know and I can change the implementation to just specific overrides of toString within GeoTrellis itself.

Removed requirement for `show` and have `toString` depend on proj4
CRS name as default representation. Maintained use of singleton class
names for predefined CRS values.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>

@echeipesh echeipesh merged commit 76032e3 into locationtech:master Sep 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@metasim metasim deleted the metasim:printable-crs branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment