New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter GeoTiffRDDs by Geometry #2409

Merged
merged 4 commits into from Oct 13, 2017

Conversation

Projects
4 participants
@jamesmcclain
Member

jamesmcclain commented Oct 5, 2017

Connects #2328

bucket: String, prefix: String,
uriToKey: (URI, I) => K,
options: Options,
geometry: Option[Geometry] = None

This comment has been minimized.

@pomadchin

pomadchin Oct 10, 2017

Member

Hm, mb to add some helpful overloads? Though it's smth to discuss, as the best otpion would be to move it into Options and it's impossible due to compatibility reasons. ):

This comment has been minimized.

@echeipesh

echeipesh Oct 12, 2017

Contributor

There also needs to be an apply with the old signature to avoid removing this method from the API.

@pomadchin

pomadchin approved these changes Oct 10, 2017 edited

Mb in 2.0 we'll move geometry into Options but for now it's good. Looks like it can be merged as is after #2402

Review TIP

@pomadchin

This comment has been minimized.

Member

pomadchin commented Oct 10, 2017

Btw a thought appeared after the review: mb it makes sense to add some extra overloads to use this filter by geometry functionality more convenient.

@jamesmcclain

This comment has been minimized.

Member

jamesmcclain commented Oct 11, 2017

Btw a thought appeared after the review: mb it makes sense to add some extra overloads to use this filter by geometry functionality more convenient.

Yes, perhaps we can do that in a subsequent PR (or not, depending on timing).

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature/geotiff-filtering branch from 4fb92b2 to bbd21aa Oct 11, 2017

@rossbernet rossbernet added this to the 1.2 milestone Oct 11, 2017

@rossbernet rossbernet added this to Needs review in 1.2 release Oct 11, 2017

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature/geotiff-filtering branch from bbd21aa to 10ec91f Oct 11, 2017

bucket: String, prefix: String,
uriToKey: (URI, I) => K,
options: Options,
geometry: Option[Geometry] = None

This comment has been minimized.

@echeipesh

echeipesh Oct 12, 2017

Contributor

There also needs to be an apply with the old signature to avoid removing this method from the API.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature/geotiff-filtering branch from 10ec91f to c33e89b Oct 12, 2017

@echeipesh echeipesh merged commit e88c094 into locationtech:master Oct 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@fosskers fosskers moved this from Needs review to DONE! in 1.2 release Oct 13, 2017

@jamesmcclain jamesmcclain deleted the jamesmcclain:feature/geotiff-filtering branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment