New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bound segment index when reading over-buffered GeoTiff window #2534

Merged
merged 2 commits into from Jan 3, 2018

Conversation

Projects
None yet
1 participant
@echeipesh
Contributor

echeipesh commented Jan 3, 2018

Overview

GeoTiffSegmentLayout.getIntersectingSegments did not perform bound checking.
As a result if GridBounds parameter was outside of the bounds of segment layout an out of bounds index would be returned, resulting in failed segment lookup.

This issue was discovered in process of performing buffered window reads: raster-foundry/raster-foundry@49fe952

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • [-] docs guides update, if necessary
  • [-] New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

@echeipesh echeipesh added the bug label Jan 3, 2018

@echeipesh echeipesh force-pushed the echeipesh:fix/getIntersectingSegments branch from 3f2e4f6 to d33b392 Jan 3, 2018

@echeipesh echeipesh referenced this pull request Jan 3, 2018

Merged

Use GeoTrellis 1.2.0 #2734

6 of 6 tasks complete

@echeipesh echeipesh force-pushed the echeipesh:fix/getIntersectingSegments branch from 8ab0162 to e0a6205 Jan 3, 2018

@echeipesh echeipesh added this to the 1.2 milestone Jan 3, 2018

@echeipesh echeipesh merged commit 86ac40c into locationtech:master Jan 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment