New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Temporal Ingests from spark-etl to S3 #2709

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
3 participants
@mattfullerton
Contributor

mattfullerton commented Jun 18, 2018

Allows Temporal Ingests from spark-etl to S3

@pomadchin

This comment has been minimized.

Member

pomadchin commented Jun 26, 2018

Hi @mattfullerton and sry for a long response! Can you squash your commits and sign it?
If you haven't signed ECA yet can you do it? After that just sign all your commits via git commit -s, more info can be found here: https://github.com/locationtech/geotrellis/blob/master/docs/CONTRIBUTING.rst#pull-requests
and you can reach us in our gitter channel to help you to get this contribution merged.

Also we don't plan to support this etl package anymore (we expect it to be dropped in 3.0) and plan to replace it with a pipeline that is not documented well at the moment, but you can find more info here: https://github.com/locationtech/geotrellis/blob/master/docs/CONTRIBUTING.rst#pull-requests

Any feedback is appreciated!

@mattfullerton mattfullerton force-pushed the HawaDawa:master branch 3 times, most recently from 91c213b to 72fb2a6 Aug 20, 2018

@mattfullerton

This comment has been minimized.

Contributor

mattfullerton commented Aug 20, 2018

Hey, now it took me a while to reply; sorry about that.

I have never seen entry hurdles this big for making a (minor) PR to an OS project. Nevertheless, I have tried to squash the commits to one and sign it with a GPG id, same as the email address that has also signed the ECA. I hope I did it all correctly.

@pomadchin

This comment has been minimized.

Member

pomadchin commented Aug 20, 2018

hey @mattfullerton thx for the update! it looks like you used git commit --amend -S (capital letter S) and not git commit --amend -s to add footers. Also I'm afraid i can't find that your email has the signed ECA, are you sure that it's a proper email?

Add Temporal GeoTiff ingest for S3
Signed-off-by: Matt Fullerton <matt.fullerton@gmail.com>

@mattfullerton mattfullerton force-pushed the HawaDawa:master branch from 72fb2a6 to 5279cb4 Aug 20, 2018

@mattfullerton

This comment has been minimized.

Contributor

mattfullerton commented Aug 20, 2018

I did the sign now with -s and signed the agreement (sorry, thought I only needed to sign up on the Foundation site)

@pomadchin

This comment has been minimized.

Member

pomadchin commented Aug 20, 2018

thanks @mattfullerton, will merge it after CI would be happy!

@pomadchin pomadchin merged commit 829b4fa into locationtech:master Aug 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@echeipesh echeipesh added this to the 2.1 milestone Aug 30, 2018

@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Oct 2, 2018

Backported to 2.1 with d2e3666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment