New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Raster[T] to T implicit conversion #2771

Merged
merged 5 commits into from Jul 31, 2018

Conversation

Projects
None yet
1 participant
@echeipesh
Contributor

echeipesh commented Jul 27, 2018

In particular this conversion results in data loss and surprising behavior.

Other remaining implicit conversion, from Raster[T] to PolygonFeature[T] at least preserve the extent information.

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • [-] docs guides update, if necessary
  • [-] New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Demo

Optional. Screenshots/REPL

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Resolves #2768

echeipesh added some commits Jul 27, 2018

Remove Raster[T] to T implicit conversion
In particular this conversion results in data loss and surprising behavior
@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Jul 27, 2018

HA, this change actually revealed a bug in GeoTiff.crop that was being ignored in the unit tests ^.

echeipesh added some commits Jul 31, 2018

@echeipesh echeipesh merged commit f092b7d into locationtech:master Jul 31, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ip-validation
Details

@echeipesh echeipesh added this to the 2.0 milestone Aug 3, 2018

echeipesh added a commit that referenced this pull request Aug 5, 2018

Backport #2771: Remove Raster[T] to T implicit conversion
Remove Raster[T] to T implicit conversion

In particular this conversion results in data loss and surprising behavior (+2 squashed commits)
Squashed commits:
[da63873] Update tests where Raster[T] is used as T
[750f159] fix: return grid aligned Extent on GeoTiff crop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment