New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inverted Extent #2812

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@pomadchin
Member

pomadchin commented Oct 1, 2018

Overview

This PR allows to handle properly such kinds of Extents:

Corner Coordinates:
Upper Left  (    0.0,    0.0)
Lower Left  (    0.0,13545.0)
Upper Right (21995.0,    0.0)
Lower Right (21995.0,13545.0)
Center      (10997.5, 6772.5)

Closes #2805

@pomadchin pomadchin added this to the 2.1 milestone Oct 1, 2018

@pomadchin pomadchin force-pushed the pomadchin:feature/fix-extent branch from acc36c0 to 4dec278 Oct 1, 2018

@pomadchin pomadchin requested a review from echeipesh Oct 1, 2018

@@ -446,7 +446,13 @@ case class TiffTags(
i += 1
}
Extent(minX, minY, maxX, maxY)
// fix an inverted extent, to behave more like GDAL

This comment has been minimized.

@pomadchin

pomadchin Oct 1, 2018

Member

do we really want to perform a silent transform or mb we can throw at least a warning?

This comment has been minimized.

@echeipesh

echeipesh Oct 2, 2018

Contributor

I'm surprised that GDAL allows this but seems like a safe conversion here.

@echeipesh echeipesh merged commit 51a1864 into locationtech:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@echeipesh

This comment has been minimized.

Contributor

echeipesh commented Oct 2, 2018

Backport to 2.1 f0700d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment