Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IO code agnostic about effects #2818

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@moradology
Copy link
Contributor

commented Oct 15, 2018

Overview

This change makes IOBackoff agnostic about the underlying effect engine used by clients at the cost of a slightly more cumbersome cats-effect API.

I'm curious - @echeipesh @pomadchin - do you guys think this is even worth it?

@moradology moradology requested a review from pomadchin Oct 15, 2018

@echeipesh echeipesh added this to the 3.0 milestone Oct 16, 2018

@pomadchin pomadchin force-pushed the feature/agnostic-effects branch from ba78075 to 5721245 Oct 19, 2018

@pomadchin
Copy link
Member

left a comment

LGTM, a nice pattern that we can use in the entire codebase in the Future. Merging after travis would be happy. Also @moradology fork the updated master branch next time :D

@pomadchin pomadchin merged commit 0ef31de into master Oct 19, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
ip-validation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.