Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed elliptical radius check in IDW algorithm. #2844

Merged
merged 1 commit into from Dec 12, 2018

Conversation

@hhowe29
Copy link
Contributor

commented Dec 7, 2018

Overview

Closes #2840

Checklist

  • Unit tests added for bug-fix or new feature

@hhowe29 hhowe29 force-pushed the hhowe29:master branch 3 times, most recently from 38193e1 to e79121a Dec 7, 2018

@pomadchin
Copy link
Member

left a comment

Thanks a lot for your contribution! LGTM, @echeipesh do we need to sign up this PR?

@pomadchin

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

Hey @hhowe29 I think that it's good to go even without CLA, but can you sign it? https://github.com/locationtech/geotrellis/blob/master/docs/CONTRIBUTING.rst#eclipse-contributor-agreement-eca

After signing just do git commit --amend -S && git push origin -f master

Modified the IDW algorithm to implement the elliptical radius check c…
…orrectly. Fixes #2840.

Signed-off-by: Harold Howe <hhowe29@gmail.com>

Fix compilation error.

@hhowe29 hhowe29 force-pushed the hhowe29:master branch from e79121a to d86afbb Dec 12, 2018

@hhowe29

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@pomadchin Think I got it right this time.

@pomadchin

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

@hhowe29 thank you so much; merging! 🎉 🎉 🎉 🎉

@pomadchin pomadchin merged commit 8c02874 into locationtech:master Dec 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ip-validation
Details
echeipesh added a commit that referenced this pull request Dec 28, 2018
Merge pull request #2844 from hhowe29/master
Fixed elliptical radius check in IDW algorithm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.