Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map{X|Y}ToGrid function behavior that could give a bit incorrect results #2953

Merged
merged 4 commits into from May 30, 2019
Merged

Fix map{X|Y}ToGrid function behavior that could give a bit incorrect results #2953

merged 4 commits into from May 30, 2019

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented May 30, 2019 •
edited

Overview

In case of negative Extent coordinates and because of a floating point errors, in case where the north and west site of the block is very close to the Int we could approximate number of cols / rows incorrectly.

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • Unit tests added for bug-fix or new feature

Closes #2918

@pomadchin pomadchin changed the title map{X|Y}ToGrid can give incorrect results Fix map{X|Y}ToGrid function behavior that could give a bit incorrect results May 30, 2019
@pomadchin pomadchin added this to the 3.0 milestone May 30, 2019
@pomadchin pomadchin merged commit e6c8cc9 into locationtech:master May 30, 2019
This was referenced Jun 18, 2019
Closed
Merged
@metasim metasim mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeipesh echeipesh echeipesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GT 3.0
Development

Successfully merging this pull request may close these issues.

RasterExtent.gridBoundsFor(subExtent, clamp) produces incorrect extent
2 participants
@pomadchin @echeipesh