Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayTile Equality Bug #2991

Merged
merged 2 commits into from Jun 16, 2019
Merged

Conversation

jbouffard
Copy link

@jbouffard jbouffard commented Jun 14, 2019

Overview

This fixes an equality bug in ArrayTile where cols, rows, and cellType of the two tiles were not taken into account. They now are.

Checklist

  • docs/CHANGELOG.rst updated, if necessary
  • Unit tests added for bug-fix or new feature

Closes #2869

Copy link
Member

@pomadchin pomadchin left a comment

Wondering, why the The CostdistanceSpec failed. Have you tried to run all tests locally?

@jbouffard
Copy link
Author

@jbouffard jbouffard commented Jun 14, 2019

@pomadchin It looks like it's failing for me locally too... I'm not sure what's up with that.

Signed-off-by: Jacob Bouffard <jbouffard@azavea.com>

Updated the CHANGELOG

Signed-off-by: Jacob Bouffard <jbouffard@azavea.com>

Added Nan check to equality

Signed-off-by: Jacob Bouffard <jbouffard@azavea.com>
@pomadchin pomadchin merged commit 3f72d4b into locationtech:master Jun 16, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants