ArrayTile Equality Bug #2991
Merged
ArrayTile Equality Bug #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbouffard
force-pushed
the
fix/arraytile-equality
branch
from
866a95e
to
35a4eca
Compare
pomadchin
approved these changes
Jun 14, 2019
pomadchin
requested changes
Jun 14, 2019
|
@pomadchin It looks like it's failing for me locally too... I'm not sure what's up with that. |
pomadchin
reviewed
Jun 14, 2019
Signed-off-by: Jacob Bouffard <jbouffard@azavea.com> Updated the CHANGELOG Signed-off-by: Jacob Bouffard <jbouffard@azavea.com> Added Nan check to equality Signed-off-by: Jacob Bouffard <jbouffard@azavea.com>
jbouffard
force-pushed
the
fix/arraytile-equality
branch
from
35a4eca
to
09472e5
Compare
pomadchin
approved these changes
Jun 14, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an equality bug in
ArrayTilewherecols,rows, andcellTypeof the two tiles were not taken into account. They now are.Checklist
docs/CHANGELOG.rstupdated, if necessaryCloses #2869