Fix TIFFTagsReader to skip unsupported tags #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
fix/tifftags-reader
branch
2 times, most recently
from
6c7f86f
to
dda7263
Compare
Signed-off-by: Grigory Pomadchin <gr.pomadchin@gmail.com>
pomadchin
force-pushed
the
fix/tifftags-reader
branch
from
dda7263
to
cd73b4c
Compare
Closed
echeipesh
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our GeoTIFF Reader supports not all the tiff tags types, this PR adds an ability to skip unknown tags. This PR partially covers #3085 but doesn't introduce
TIFFTAG_EXIFIFDtag support.Checklist
docs/CHANGELOG.rstupdated, if necessary