Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary calculations. #3147

Open
wants to merge 1 commit into
base: master
from

Conversation

@esmeetu
Copy link

esmeetu commented Nov 6, 2019

Overview

remove unnecessary slope and aspect calculations.

Checklist

  • Unit tests added for bug-fix or new feature

Notes

Two questions:

  1. In terms of zFactor, should it be better to put this parameter to SurfacePointCalculation class?
    in method calcSurface like this:
s.`dz/dx` = zFactor * (neValue + 2*eValue + seValue - nwValue - 2*wValue - swValue) / (8 * cellWidth)
s.`dz/dy` = zFactor * (swValue + 2*sValue + seValue - nwValue - 2*nValue - neValue) / (8 * cellHeight)
  1. in the expression resultTile.set(x, y, round(127.0 * max(0.0, v)).toInt) of the commited file, why 127.0 is set here while it is 255.0 in https://desktop.arcgis.com/en/arcmap/10.3/tools/spatial-analyst-toolbox/how-hillshade-works.htm
@pomadchin

This comment has been minimized.

Copy link
Member

pomadchin commented Nov 7, 2019

Hey @esmeetu thanks for your contribution! Can you please sign an ECA? https://github.com/locationtech/geotrellis/blob/master/docs/CONTRIBUTING.rst#eclipse-contributor-agreement-eca after signing it just do git commit --amend -s && git push origin -f master

Signed-off-by: yswang <jasonailu87@hotmail.com>
@esmeetu esmeetu force-pushed the esmeetu:master branch from b7980fc to 3b3e213 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.