Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove min/max in computing CellType for GDALDataset #3150
GDAL's type system is narrower than GT
In GDALUtils.dataTypeToCellType, only get unsigned Byte by passing in appropriate min and max. This is to avoid breaking the existing call behavior.
Some gitter discussion on the topic here
…aset GDAL's type system is narrower than GT GDALDataType.GDT_Byte maps to UByte* only depending on NoData In GDALUtils.dataTypeToCellType, only get unsigned Byte by passing in appropriate min and max. Signed-off-by: Jason T. Brown <email@example.com>
@vpipkt btw so what about tests? This PR in general makes sense, but I remember that we introduced these changes to make it behave like
I also would like to mention @notthatbreezy since he can be intrested in this change and mb will help us to test it out.