Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make withGetBoundsMethod serializable #3152

Merged
merged 1 commit into from Nov 14, 2019
Merged

Conversation

@kervel
Copy link
Contributor

kervel commented Nov 13, 2019

Signed-off-by: Frank Dekervel frank@kapernikov.com

Overview

without this, trying to do getBounds on a RDD will result in a serialisation error on spark 2.4.4.
with this trivial change applied, getBounds works without error.

Demo

Optional. Screenshots/REPL

Notes

I did not update any other code as this change is completely trivial and in line with the rest of the classes in the same file.

Frank Dekervel
without this, trying to do getBounds on a RDD will result in a serialisation error on spark 2.4.4.

Signed-off-by: Frank Dekervel <frank@kapernikov.com>
Copy link
Member

pomadchin left a comment

Nice, thanks for you contribution and gz with the first one! 🎉 🎉 🎉 ill merge it in the morning after adding an entry into the change log.

@pomadchin pomadchin added the bug label Nov 14, 2019
@pomadchin pomadchin self-assigned this Nov 14, 2019
@echeipesh echeipesh merged commit c99dc66 into locationtech:master Nov 14, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@pomadchin

This comment has been minimized.

Copy link
Member

pomadchin commented Nov 14, 2019

upd: we decided even not to leave a change log; it would be added as a bug fix later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.