Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forced truncation of WKT types in Markdown/HTML rendering. #408

Merged
merged 1 commit into from Nov 8, 2019

Conversation

metasim
Copy link
Member

@metasim metasim commented Nov 5, 2019

Closes #407

@metasim metasim requested a review from vpipkt Nov 5, 2019
@@ -47,8 +49,9 @@ trait DataFrameRenderers {
lit("\"></img>")
Copy link
Member Author

@metasim metasim Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if the line above this one

 base64(rf_render_png(rf_resample(resolved, 0.5), ColorRamps.Viridis))

should be changed to use ColorRamps.greyscale(256), and then apply a color ramp in the python API for notebooks.

Copy link
Member

@vpipkt vpipkt Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk

Copy link
Member Author

@metasim metasim Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Damn. Didn't think of that.

@@ -47,8 +49,9 @@ trait DataFrameRenderers {
lit("\"></img>")
Copy link
Member

@vpipkt vpipkt Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk

vpipkt
vpipkt approved these changes Nov 6, 2019
@vpipkt
Copy link
Member

@vpipkt vpipkt commented Nov 6, 2019

🚢 it

@metasim metasim merged commit b6c1ce0 into locationtech:develop Nov 8, 2019
2 checks passed
@metasim metasim deleted the fix/407 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants