Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forced truncation of WKT types in Markdown/HTML rendering. #408

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@metasim
Copy link
Member

metasim commented Nov 5, 2019

Closes #407

@metasim metasim requested a review from vpipkt Nov 5, 2019
@@ -47,8 +49,9 @@ trait DataFrameRenderers {
lit("\"></img>")

This comment has been minimized.

Copy link
@metasim

metasim Nov 5, 2019

Author Member

Wondering if the line above this one

 base64(rf_render_png(rf_resample(resolved, 0.5), ColorRamps.Viridis))

should be changed to use ColorRamps.greyscale(256), and then apply a color ramp in the python API for notebooks.

This comment has been minimized.

Copy link
@vpipkt

vpipkt Nov 6, 2019

Member

I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk

This comment has been minimized.

Copy link
@metasim

metasim Nov 8, 2019

Author Member

Good point. Damn. Didn't think of that.

@@ -47,8 +49,9 @@ trait DataFrameRenderers {
lit("\"></img>")

This comment has been minimized.

Copy link
@vpipkt

vpipkt Nov 6, 2019

Member

I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk

@vpipkt
vpipkt approved these changes Nov 6, 2019
@vpipkt

This comment has been minimized.

Copy link
Member

vpipkt commented Nov 6, 2019

🚢 it

@metasim metasim merged commit b6c1ce0 into locationtech:develop Nov 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@metasim metasim deleted the s22s:fix/407 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.