Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded forced truncation of WKT types in Markdown/HTML rendering. #408
Conversation
| @@ -47,8 +49,9 @@ trait DataFrameRenderers { | |||
| lit("\"></img>") | |||
This comment has been minimized.
This comment has been minimized.
metasim
Nov 5, 2019
Author
Member
Wondering if the line above this one
base64(rf_render_png(rf_resample(resolved, 0.5), ColorRamps.Viridis))
should be changed to use ColorRamps.greyscale(256), and then apply a color ramp in the python API for notebooks.
This comment has been minimized.
This comment has been minimized.
vpipkt
Nov 6, 2019
Member
I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk
This comment has been minimized.
This comment has been minimized.
| @@ -47,8 +49,9 @@ trait DataFrameRenderers { | |||
| lit("\"></img>") | |||
This comment has been minimized.
This comment has been minimized.
vpipkt
Nov 6, 2019
Member
I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk
This comment has been minimized.
This comment has been minimized.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metasim commentedNov 5, 2019
•
edited
Closes #407