Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Rfc geoscript console #164

Merged
merged 50 commits into from

2 participants

@moovida

This is the pull request to get the Geoscript Console in uDig.

It also contains the doc page for the editor.

RFC here: http://udig.refractions.net/confluence/display/UDIG/Addition+of+a+Geoscript+Console

moovida added some commits
@moovida moovida first import of the original geoscript plugin 96057d6
@moovida moovida rename to reflect udig namespace b43f3a9
@moovida moovida claenup cdb79db
@moovida moovida cleanup wip 421f3b8
@moovida moovida license files 1a851d7
@moovida moovida refactor to proper namespace 7cb8ac6
@moovida moovida cleanup wip 8cc1007
@moovida moovida groovy scripts cf5801a
@moovida moovida modules in code scanner updated b3fe3e8
@moovida moovida output fields were missing b327f1b
@moovida moovida add geoscript dependency c219bcf
@moovida moovida gathering modules first draft aligned with spatial toolbox ca795f2
@moovida moovida cleanup and alignment with ST - first draft a0866ee
@moovida moovida editor opening cbb3675
@moovida moovida license update 06576c9
@moovida moovida cleanup wip 978207e
@moovida moovida add json jar dependency 47c1d13
@moovida moovida some syntax tweak tests 6bcb5fb
@moovida moovida keywords in outside folder with cache 289822a
@moovida moovida keywords from file gathering f382187
@moovida moovida proper script name for console 2e11e3b
@moovida moovida improvments in syntax coloring 3510946
@moovida moovida adding all necessary dependencies c2f7008
@moovida moovida proper libs for geoscript 4e2b94c
@moovida moovida proper sorting 98d9401
@moovida moovida common imports are more usful a50c393
@moovida moovida solving the jcommons 13-16 problem that some of us have 725a9f9
@moovida moovida added drag and drop support 28625eb
@moovida moovida methods completion starts to work b0c17bb
@moovida moovida crtl-space to trigger command completion 69aeba5
@moovida moovida word completion enhancements cd107d6
@moovida moovida added many completion proposals 37d5334
@moovida moovida put editor actions inside editor 3c40e8d
@moovida moovida proper stop script notification b1467b3
@moovida moovida completion tweaks 2f534fd
@moovida moovida adding heap and log combos f3876e8
@moovida moovida remove oms parts fd785e9
@moovida moovida removing unused stuff be618c5
@moovida moovida filter away non GIS stuff from the ide and editor plugins 2f40e72
@moovida moovida adding the plugins to the game 53c4731
@moovida moovida spatial toolbox classes and methods 098be7e
@moovida moovida textfield fix 631da36
@moovida moovida better handling of docs and loading of modules 1bee376
@moovida moovida final tweaks on syntax and completion 3f04b82
@moovida moovida missing methods c5dfff2
@moovida moovida draft editor page - to be properly written 8a38933
@moovida moovida Update docs/user/en/The Geoscript Editor.rst
Geoscript editor docs
e575d09
@moovida moovida Update docs/user/en/The Geoscript Editor.rst 6b3a770
@moovida moovida Update docs/user/en/The Geoscript Editor.rst f71ec2c
@moovida moovida Merge branch 'master' into rfc_geoscript_console 0ab1dda
@jodygarnett
Collaborator

Thanks Moovida! It really helps having an example

@jodygarnett jodygarnett commented on the diff
plugins/net.refractions.udig.libs/build.properties
@@ -13,7 +13,18 @@ bin.includes = .,\
about.html,\
@jodygarnett Collaborator

I see about.html mentioned, but cannot figure out how to view it from github. So with about.html, ell and hsd3 license we should be good to go

@moovida
moovida added a note

The about.html has not been edited. It is probably mentioned in the diff, because it has been moved when updating the libs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jodygarnett jodygarnett commented on the diff
plugins/net.refractions.udig.libs/build.properties
@@ -13,7 +13,18 @@ bin.includes = .,\
about.html,\
bsd3-v10.html,\
@jodygarnett Collaborator

This may be the hydrologis take on a BSD license (often hsd3-v10.html)

@moovida
moovida added a note

What do you mean here?

@jodygarnett Collaborator

I was looking for they three key license files (about.html summary, epl license, and hsd license)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jodygarnett
Collaborator

I found it easiest to browse https://github.com/uDig/udig-platform/tree/rfc_geoscript_console/plugins/eu.udig.jconsole to review the proposed files.

License review:

  • epl and hsd check out okay (yay!)
  • about.html is missing (this is what the help dialog shows, it links to esd and hsd files)

Docs:

  • we have documentation page!

Spot check on headers:

  • JConsolePlugin <-- missing header
  • JavaActionContributor.java <-- IBM header (assume they did not set this up for reuse, will need to note in about.html)
  • JavaEditorDocumentProvider.java <-- standard hydroloGIS header (EPL and HSD)

Suggestions for discussion:

  • So we should search for missing headers? Either now or do an IP check later (need to find an example of about.html)
  • The JavaEditorDocumentProvider, this is from an example I presume, since we are not editing in Java can this be refactored to say GeoScriptDocumentProvider?

Suggestion: Accept this pull request as is (so it does not go stale) and add a few tasks to the RFC:

  • IP check of headers and about.html
  • Refactor for GeoScript rather than Java (or even GSDocumentProvider
@moovida

Comments inline.

License review:

  • epl and hsd check out okay (yay!)
  • about.html is missing (this is what the help dialog shows, it links to esd and hsd files)

What is this thing about the about.html file? What do you want me to do?

Spot check on headers:

  • JConsolePlugin <-- missing header

outch, adding it after pull if ok.

  • JavaActionContributor.java <-- IBM header (assume they did not set this up for reuse, will need to note in about.html)

Why do you think it is not for reuse. Isn't it EPL, which is our base license? It should be ok?

  • JavaEditorDocumentProvider.java <-- standard hydroloGIS header (EPL and HSD)

ok

Suggestions for discussion:

  • So we should search for missing headers? Either now or do an IP check later (need to find an example of about.html)
  • The JavaEditorDocumentProvider, this is from an example I presume, since we are not editing in Java can this be refactored to say GeoScriptDocumentProvider?

Yes, you are right, All the Java* should get Geoscript*. I liked the fact that it would support also Groovy, so I wa snot shure what to rename it. So I forgot :)

Suggestion: Accept this pull request as is (so it does not go stale) and add a few tasks to the RFC:

  • IP check of headers and about.html
  • Refactor for GeoScript rather than Java (or even GSDocumentProvider

Agreed on everything. Need more directions regarding the about file.

@jodygarnett
Collaborator

More information on about.html:

Or uDig specific:

@jodygarnett jodygarnett merged commit b0e786f into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 3, 2013
  1. @moovida
  2. @moovida
  3. @moovida

    claenup

    moovida authored
  4. @moovida

    cleanup wip

    moovida authored
  5. @moovida

    license files

    moovida authored
  6. @moovida

    refactor to proper namespace

    moovida authored
  7. @moovida

    cleanup wip

    moovida authored
  8. @moovida

    groovy scripts

    moovida authored
  9. @moovida
  10. @moovida

    output fields were missing

    moovida authored
  11. @moovida

    add geoscript dependency

    moovida authored
  12. @moovida
  13. @moovida
Commits on Jan 4, 2013
  1. @moovida

    editor opening

    moovida authored
  2. @moovida

    license update

    moovida authored
  3. @moovida

    cleanup wip

    moovida authored
  4. @moovida

    add json jar dependency

    moovida authored
  5. @moovida

    some syntax tweak tests

    moovida authored
  6. @moovida
  7. @moovida

    keywords from file gathering

    moovida authored
  8. @moovida
  9. @moovida
  10. @moovida
  11. @moovida

    proper libs for geoscript

    moovida authored
  12. @moovida

    proper sorting

    moovida authored
  13. @moovida

    common imports are more usful

    moovida authored
Commits on Jan 5, 2013
  1. @moovida
  2. @moovida

    added drag and drop support

    moovida authored
  3. @moovida
  4. @moovida
  5. @moovida

    word completion enhancements

    moovida authored
  6. @moovida
  7. @moovida
  8. @moovida
Commits on Jan 7, 2013
  1. @moovida

    completion tweaks

    moovida authored
  2. @moovida

    adding heap and log combos

    moovida authored
  3. @moovida

    remove oms parts

    moovida authored
  4. @moovida

    removing unused stuff

    moovida authored
  5. @moovida
  6. @moovida
Commits on Jan 8, 2013
  1. @moovida
Commits on Jan 9, 2013
  1. @moovida

    textfield fix

    moovida authored
Commits on Jan 13, 2013
  1. @moovida
  2. @moovida
  3. @moovida

    missing methods

    moovida authored
  4. @moovida
  5. @moovida

    Update docs/user/en/The Geoscript Editor.rst

    moovida authored
    Geoscript editor docs
  6. @moovida
  7. @moovida
  8. @moovida
Something went wrong with that request. Please try again.