Fix broken DB2 plug-in #209
Conversation
|
Kicked Hudson build : https://hudson.locationtech.org/udig/job/uDig-PR-NG/35 |
| * @author Jesse Eichar, jeichar, for Refractions Research, Inc. | ||
| * @author Richard Gould, rgould, for Refractions Research, Inc. | ||
| * @author Adrian Custer, acuster. | ||
| * @since 1.0.1 | ||
| * @author David Adler, dadler, for AdtechGeospatial | ||
| * @since 2.0.x |
There was a problem hiding this comment.
David, I guess since 1.0.1 includes 2.0.x for API docs. I'd like to suggest to remove the second one. Or ist there any other intention to add 2.0.x?
There was a problem hiding this comment.
Frank, not sure what I was thinking. What release will this be going into? I wanted to have some indication of history for the changes.
There was a problem hiding this comment.
Target release is 2.x, I guess its better to track changes for a release in locationtech bugzilla (for the monent), I filed an enhancement for your maintanance work : https://locationtech.org/bugs/show_bug.cgi?id=98
There was a problem hiding this comment.
When and what is the next release to go out? I would like to get these fairly minor fixes in as soon as possible.
Should I change the prologs and commit again?
|
Many thanks David! Does the fix changes the UI of the wizard page (http://udig.github.io/docs/user/reference/DB2%20page.html) or the workflow how to add data (http://udig.github.io/docs/user/tasks/Adding%20Features%20from%20DB2.html)? I assume the preferences and suggested jar-Names (http://udig.github.io/docs/user/reference/Catalog%20Preferences.html#preferences-page-catalog-db2) are still valid, aren't they? |
| @@ -15,5 +15,7 @@ DB2WizardPage_installDrivers=Install DB2 drivers from client | |||
| DB2WizardPage_connectionTask=Attempting to make database connection | |||
| DB2WizardPage_warning=An error will occur because the DB2 drivers were not loaded. Please restart application | |||
| DB2WizardPage_title=DB2 Wizard | |||
| DB2WizardPage_button_lookup_text=Get schemas | |||
There was a problem hiding this comment.
This is a new button, right? I guess the Wizard Page screenshot should be updated and if necessary, description workflow as well [Adding features from DB2](docs/user/en/tasks/Adding Features from DB2.rst)
There was a problem hiding this comment.
The screenshot needs to be changed - how should it be provided?
The "Adding features from ..." doesn't seem useful for ArcSDE, DB2 or Oracle - it is basically the shapefile instructions. It is correct for PostGIS.
How can I update this information for DB2?
There is no change to the preferences page.
There was a problem hiding this comment.
Take a screenshot of the wizard page and store it down below 'docs/user/en/images/db2_page/' as DB2.jpg
Add it to stage and commit it like other sources. That's should be enought.
We can separate the cleanup task for docs from this commit ("Add features ..") and move on ;).
There was a problem hiding this comment.
I would be happy to update the Add features for DB2 documentation but don't know how to process the .rst files. udig\docs\readme.txt describes how to install sphinx but not how to build ;-)
There was a problem hiding this comment.
Its easier than expected: Just build with option -Pdocs (Details here). Output html you can find down below doc/target
HTH
There was a problem hiding this comment.
I tried to build with
mvn clean install -Pdocs
but it failed with:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:53 min
[INFO] Finished at: 2016-05-19T19:04:21-05:00
[INFO] Final Memory: 290M/1619M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.3:
run (package) on project udig-docs: An Ant BuildException has occured: J:\udig\d
ocs\target\user\en\simple not found. -> [Help 1]
[ERROR]
There was a problem hiding this comment.
Its required to have Sphinx installed (see docs/readme.txt). You can test it within the docs-module with mvn clean package first. Internally ant is called and watch out for errors/warnings in the log
There was a problem hiding this comment.
I've updated and committed the add DB2 features documentation.
You mentioned previously collapsing the commits - that is fine.
When do you think this can be integrated to master?
Although the DB2 plug-in had worked many years ago, it currently failed completely when selecting DB2 from the "Add Layer" dialog.
By debugging with Eclipse I've been able to fix most of the problems, select tables to be displayed and display them once the project is re-opened. Obsolete commented-out code has been removed, spellings fixed and some comments added.
There are still some problems selecting features from multiple schemas but I would like to have the current fixes integrated if they are acceptable.