New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OpenStyleEditorAction to select a more appropriate StyleEditorPage #210

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
2 participants
@cmhodgson
Contributor

cmhodgson commented May 11, 2016

Changed the OpenStyleEditorAction to look through the loaded StyleEditorPage extensions instead of using Class.forName() (which wasn't working because the StyleEditorPages are loaded by a
different classloader).

Signed-off-by: Chris Hodgson chodgson@refractions.net

Changed the OpenStyleEditorAction to look through the
loaded styleEditorPage extensions instead of using Class.forName()
(which wasn't working because the styleEditorPages are loaded by a
different classloader).

Signed-off-by: Chris Hodgson <chodgson@refractions.net>
@cmhodgson

This comment has been minimized.

Contributor

cmhodgson commented May 11, 2016

I have now signed the eclipse CLA. Is there a way to redo the checks? Or do I need to redo the pull request?

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented May 11, 2016

Its a diff that's down below 1000 line- change. Therefore it should be
enought if you sign your commit with the -s option for git

Please reset your commit, commit again with -s and push the branch with
force-option again.

HTH

Am Mittwoch, 11. Mai 2016 schrieb Chris Hodgson :

I have now signed the eclipse CLA. Is there a way to redo the checks? Or
do I need to redo the pull request?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#210 (comment)

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented May 11, 2016

Just saw, you signed off already. I remember there is an open issue for the
commit checks. I'm going to have a look at

Frank

Am Mittwoch, 11. Mai 2016 schrieb Frank Gasdorf :

Its a diff that's down below 1000 line- change. Therefore it should be
enought if you sign your commit with the -s option for git

Please reset your commit, commit again with -s and push the branch with
force-option again.

HTH

Am Mittwoch, 11. Mai 2016 schrieb Chris Hodgson :

I have now signed the eclipse CLA. Is there a way to redo the checks? Or
do I need to redo the pull request?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#210 (comment)

@cmhodgson

This comment has been minimized.

Contributor

cmhodgson commented May 11, 2016

Thanks Frank just let me know if you need anything more from me.

@cmhodgson

This comment has been minimized.

Contributor

cmhodgson commented May 11, 2016

Let me try closing this pull request and re-opening. Now that I have signed the Eclipse CLA maybe it will work.

@cmhodgson cmhodgson closed this May 11, 2016

@cmhodgson cmhodgson reopened this May 11, 2016

@cmhodgson

This comment has been minimized.

Contributor

cmhodgson commented May 11, 2016

OK now we're good to go!?

@fgdrf fgdrf merged commit cca13a2 into locationtech:master May 17, 2016

1 check passed

ip-validation
Details

@cmhodgson cmhodgson deleted the cmhodgson:fix-open-style-editor branch May 17, 2016

@cmhodgson

This comment has been minimized.

Contributor

cmhodgson commented May 17, 2016

Thanks Frank!

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 10, 2017

@fgdrf fgdrf added the bug label Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment