Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed workspace and configuration defaults (install dir on windows is… #213

Merged
merged 1 commit into from Mar 14, 2017

Conversation

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Aug 15, 2016

… read-only, using LOCALAPPDATA

Tested RC 2.0.0.RC1 Installer on Win x86_64 but uDig never started. The Install-Dir was read-only and therefore Eclipse Defaults doesn't make sense.

This fix sets workspace and configuration area to sub-directory in %LOCALAPPDATA% on Windows-platform only.

Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net

… read-only, using LOCALAPPDATA

Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 11, 2017

@egouge Could you test this behavior on Windows?

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 11, 2017
@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 13, 2017

@nprigour If your products running on Windows, could you test and verify this fix? Would be great if you can have a look at it and review changes...
Many Thanks

@nprigour
Copy link
Contributor

@nprigour nprigour commented Mar 14, 2017

Hi @fgdrf ,
The property value for the configuration area should be osgi.configuration.area and not osgi.configuration.area.default in order to have a local configuration area created (under %LOCALAPPDATA% sub-directory). This is a needed for a share configuration otherwise the default configuration directory located at the root installation folder is used and modified which may cause problems in case or read only installations.
see also http://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fmulti_user_installs.html
Other than that I think the changes are OK

@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 14, 2017

Thanks for your feedback! Here the explanation why I used osgi.configuration.area.default over osgi.configuration.area.

From : Eclipse Runtime Options:
osgi.configuration.area.default
the default configuration location for this run of the platform. The configuration determines what plug-ins will run as well as various other system settings. This value (i.e., the default setting) is only used if no value for the osgi.configuration.area is set. See the section on locations for more details

I decided to use this option and give users the opportunity to overwrite "default" on Windows with -configuration / -Dosgi.configuration.area= for their needs.

@fgdrf fgdrf merged commit 5ec62b7 into locationtech:master Mar 14, 2017
1 check passed
1 check passed
ip-validation
Details
@fgdrf fgdrf deleted the fgdrf:win-osgi-product-config branch Mar 14, 2017
@egouge
Copy link
Contributor

@egouge egouge commented Mar 14, 2017

A little late, but I did eventually test this and it worked fine for me.

@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 14, 2017

@egouge Thank you very much for confirming the fix works on another box than mine too :)

@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 14, 2017

Good finding. I guess the problem comes from "the installer configuration" where is should set dependent from the platform the installer is made for

  • 32bit : $PROGRAMFILES
  • 64bit : $PROGRAMFILES64

Details : http://nsis.sourceforge.net/Reference/$PROGRAMFILES

@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 15, 2017

@egouge Created a bug for installer 64bit issue : https://bugs.locationtech.org/show_bug.cgi?id=142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.