Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in scalebar and scaleDenom mapgraphics #219

Merged

Conversation

@nprigour
Copy link
Contributor

@nprigour nprigour commented Mar 9, 2017

Improvements include:

  1. scalebar mapgraphic always starts from a value 0 (for bar types <>BarType.SIMPLE)
  2. scaleDenom (map scale) mapgrahic style configurator improved by adding the ability to display a cutome label in front of the map scale (see also attached screenshot)
    scaledenominator_mapgraphic

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Copy link
Contributor

@fgdrf fgdrf left a comment

@nprigour Thanks for this pull request!
I'm not sure about encoding and save/restore behavior after restart. Which encoding is used to store the label text in the Memento? Is it worth to test with different encodings here?

@egouge What do you think from another user perspective? IMHO its worth to merge it into codebase and uses can Just name the scale in their language.

@egouge
Copy link
Contributor

@egouge egouge commented Mar 9, 2017

As long as this is optional & special characters from other languages work I think this is fine.

Copy link
Contributor

@fgdrf fgdrf left a comment

It would be great if you could add a screenshot for a page listed in https://udig.github.io/docs/user/reference/Style%20Pages.html and describe the option shown in the screenshot

If you need help, let me know. Normally the the RST Markdown is straight forward to write, there is a little sphinx guide you can find here and the rst files you can finde down below docs

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 10, 2017
@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Mar 10, 2017

@egouge Thanks for your feedback! Have you tested changes on your machine? I haven't tested yet, going to test it this afternoon

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour
Copy link
Contributor Author

@nprigour nprigour commented Mar 10, 2017

from some testing I performed I do not think there is any problem with the memento saving and restore.

sphinx documentation updated

@fgdrf

This comment has been minimized.

Copy link
Contributor

@fgdrf fgdrf commented on docs/user/en/reference/Style Pages.rst in 580e2fa Mar 10, 2017

Great! This was the reason, I coundn't find it browsing through the docs

@fgdrf fgdrf merged commit d9e7a55 into locationtech:master Mar 10, 2017
@fgdrf fgdrf added the improvement label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants