Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for locationtech bug 140 #228

Merged
merged 1 commit into from May 28, 2017
Merged

fix for locationtech bug 140 #228

merged 1 commit into from May 28, 2017

Conversation

@nprigour
Copy link
Contributor

@nprigour nprigour commented May 12, 2017

A fix for bug 140 (see https://bugs.locationtech.org/show_bug.cgi?id=140). It seems that for ShapefileDataStore the transaction mode is not set to AutoCommit by default.

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

(https://bugs.locationtech.org/show_bug.cgi?id=140)

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@eclipsewebmaster
Copy link

@eclipsewebmaster eclipsewebmaster commented May 12, 2017

@nprigour
Copy link
Contributor Author

@nprigour nprigour commented May 15, 2017

Can you explain why the pull request failed. The bug refers to locationtech bug (for udig) and has nothing to do with the eclipse issue you mention above.
The past months I had created a number of pull request for udog without any such issue.
If an ECA is really needed (until now I was informed that I need to be a commiter only in the case the changes affected more than 1000 lines of code) can you advice on how to do it.

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented May 16, 2017

I'm wondering about the result of the ip-validation. It seems it changed, I'm going to clarify with Eclipse webmaster. In addition we raised a bug for wrong link generation for locationtech github projects https://bugs.locationtech.org/show_bug.cgi?id=75

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented May 16, 2017

@nprigour Do you have an Eclipse account? if so, please try to login and "sign" the ECA, this may help. If you don't have an account, I'll try to find out what we need to get it approved.

@nprigour
Copy link
Contributor Author

@nprigour nprigour commented May 16, 2017

@fgdrf I just signed the ECA. Please advise on next actions

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented May 19, 2017

@jodygarnett Could you please have a look at? From my point of view and what the Bug states it looks like patch fixes it.

@fgdrf fgdrf added this to the uDig-2.0.0 milestone May 19, 2017
@fgdrf fgdrf requested review from jodygarnett and fgdrf May 19, 2017
@fgdrf
fgdrf approved these changes May 19, 2017
Copy link
Contributor

@fgdrf fgdrf left a comment

Whenever a layer haven't had a transaction, a new one is introduced. This especially happens if a target layer is hit by drag&drop operations or even edits on the Table while no edit tools were involved.

👍 to merge it

@fgdrf fgdrf merged commit 9c2982d into locationtech:master May 28, 2017
1 check passed
1 check passed
ip-validation
Details
@fgdrf fgdrf added the bug label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.