New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for locationtech bug 140 #228
Conversation
(https://bugs.locationtech.org/show_bug.cgi?id=140) Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Issue tracker reference: |
Can you explain why the pull request failed. The bug refers to locationtech bug (for udig) and has nothing to do with the eclipse issue you mention above. |
I'm wondering about the result of the ip-validation. It seems it changed, I'm going to clarify with Eclipse webmaster. In addition we raised a bug for wrong link generation for locationtech github projects https://bugs.locationtech.org/show_bug.cgi?id=75 |
@nprigour Do you have an Eclipse account? if so, please try to login and "sign" the ECA, this may help. If you don't have an account, I'll try to find out what we need to get it approved. |
@fgdrf I just signed the ECA. Please advise on next actions |
@jodygarnett Could you please have a look at? From my point of view and what the Bug states it looks like patch fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever a layer haven't had a transaction, a new one is introduced. This especially happens if a target layer is hit by drag&drop operations or even edits on the Table while no edit tools were involved.
A fix for bug 140 (see https://bugs.locationtech.org/show_bug.cgi?id=140). It seems that for ShapefileDataStore the transaction mode is not set to AutoCommit by default.
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com