Skip to content

fix for locationtech bug 167#234

Merged
fgdrf merged 1 commit intolocationtech:masterfrom
nprigour:bug-167_fix
Jun 1, 2017
Merged

fix for locationtech bug 167#234
fgdrf merged 1 commit intolocationtech:masterfrom
nprigour:bug-167_fix

Conversation

@nprigour
Copy link
Contributor

fix for locationtech bug 167 (https://bugs.locationtech.org/show_bug.cgi?id=167)

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

(https://bugs.locationtech.org/show_bug.cgi?id=167)

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@eclipsewebmaster
Copy link

eclipsewebmaster commented May 31, 2017

Issue tracker reference:
https://bugs.locationtech.org/show_bug.cgi?id=167

@fgdrf fgdrf merged commit 402651a into locationtech:master Jun 1, 2017
@nprigour
Copy link
Contributor Author

nprigour commented Jun 1, 2017

@fgdrf there was a mistake in my code. Line 123 should check for not NULL
if (ds.getDataSource() == null) { --> if (ds.getDataSource() != null) {
Can we reopen it? Otherwise we should revert and fix the code to the pull request before re-committing

@fgdrf
Copy link
Contributor

fgdrf commented Jun 1, 2017

Fixed it with commit 482c4a7

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Jun 1, 2017
@fgdrf fgdrf added the bug label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants