New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for locationtech bug 167 #234

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@nprigour
Contributor

nprigour commented May 31, 2017

fix for locationtech bug 167 (https://bugs.locationtech.org/show_bug.cgi?id=167)

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

fix for locationtech bug 167
(https://bugs.locationtech.org/show_bug.cgi?id=167)

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@eclipsewebmaster

This comment has been minimized.

eclipsewebmaster commented May 31, 2017

@fgdrf fgdrf merged commit 402651a into locationtech:master Jun 1, 2017

1 check passed

ip-validation
Details
@nprigour

This comment has been minimized.

Contributor

nprigour commented Jun 1, 2017

@fgdrf there was a mistake in my code. Line 123 should check for not NULL
if (ds.getDataSource() == null) { --> if (ds.getDataSource() != null) {
Can we reopen it? Otherwise we should revert and fix the code to the pull request before re-committing

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented Jun 1, 2017

Fixed it with commit 482c4a7

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Jun 1, 2017

@fgdrf fgdrf added the bug label Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment