New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for location udig bug-166 #235

Merged
merged 2 commits into from Jun 2, 2017

Conversation

Projects
None yet
2 participants
@nprigour
Contributor

nprigour commented Jun 1, 2017

fix for location udig bug-166
(https://bugs.locationtech.org/show_bug.cgi?id=166) related to Map
restoration from file

nprigour added some commits May 31, 2017

fix for location udig bug-166
(https://bugs.locationtech.org/show_bug.cgi?id=166) related to Map
restoration from file

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@nprigour

This comment has been minimized.

Contributor

nprigour commented Jun 1, 2017

It seems that the provided commit fixes the problem in windows OS.
@fgdrf are you able to check it in other operating systems (i.e. linux)

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented Jun 1, 2017

See my comments on the BUG 166

@nprigour

This comment has been minimized.

Contributor

nprigour commented Jun 2, 2017

Hi @fgdrf,
In order to assist me in debug:

  1. temporary apply the attached projectImpl_debug.patch (adds some system.out prints for debug purpose)
  2. delete all .umap files from disk
  3. start udig (create a couple of Maps) and exit
  4. restart udig
  5. collect the print out results and send them to me by email.

projectImpl_debug.zip

@fgdrf

This comment has been minimized.

Contributor

fgdrf commented Jun 2, 2017

@nprigour I tested today again and I was wondering that my build was quite fast :) Now I found out that I started an older compiled product than expected because I missed to use -Pproduct for the maven build.

Finally I can confirm, that your fix works on MacOSX. Therefore I'm going to squash commits soon

@fgdrf fgdrf added this to the uDig-2.0.0 milestone Jun 2, 2017

@fgdrf fgdrf merged commit b2eb6e4 into locationtech:master Jun 2, 2017

1 check passed

ip-validation
Details
@fgdrf

This comment has been minimized.

Contributor

fgdrf commented Jun 2, 2017

Just to clarify : Whenever a project resource (e.g. a Map) is deleted using the context menu in the layers view the resource on the filesystem is not deleted. Files of deleted resources are still present and are not removed closing uDig application. This is possible another issue ..

@nprigour

This comment has been minimized.

Contributor

nprigour commented Jun 4, 2017

@fgdrf shouldn't we also check it in a linux environment before accepting it?

Concerning the deletion of resources in the file system it is another thing which however is to a large extend related to the solution we provide to this one. I have filed a seperate bug report on that (see https://bugs.locationtech.org/show_bug.cgi?id=168) and will soon provide a fix via a pull request provided that the present pull request is tested in all major platforms (windows, macOS, linux).

@nprigour

This comment has been minimized.

Contributor

nprigour commented Jun 6, 2017

Fix verified successfully also in Linux (Ubuntu) environment.

@fgdrf fgdrf added the bug label Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment