Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map project file not deleted from file system fix locationtech [bug-168] #237

Merged
merged 1 commit into from Aug 23, 2017
Merged

Map project file not deleted from file system fix locationtech [bug-168] #237

merged 1 commit into from Aug 23, 2017

Conversation

nprigour
Copy link
Contributor

@nprigour nprigour commented Jun 6, 2017 •
edited by fgdrf

Provides a fix for locationtech bug-168 related to Map file deletion from disk.
Pull request #235 must be applied before accepting this

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

@nprigour
fix for location udig bug-168
215306a 
(https://bugs.locationtech.org/show_bug.cgi?id=168) related to Map file
deletion from disk 

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
@fgdrf
Copy link
Contributor

fgdrf commented Aug 23, 2017

Does the change fix UDIG-1974?

@fgdrf
Copy link
Contributor

fgdrf commented Aug 23, 2017

Verified ✔️ that it works fine on windows, project-files (*.umap) are deleted. I'm wondering about log-entries for a deleted map, if it was created within the same session:
!ENTRY org.locationtech.udig.project 1 0 2017-08-23 10:56:37.662
!MESSAGE Not saving file://<path-to-workspace>\project.udig\Map.umap empty contents

Is it worth to have feedback like this or does it makes sense to avoid this logging-entry to avoid confusions?

@fgdrf fgdrf added the bug label Aug 23, 2017
@fgdrf fgdrf added this to the uDig-2.0.0 milestone Aug 23, 2017
@nprigour
Copy link
Contributor Author

I would say that UDIG-1974 is more related to locationtech-bug-166 which is addressed by pull request #235.

Concerning the logging I do not think it is completely useless. It is logged at INFO level and may also occur in the case a new project exists without a map or other resource beneath. I opt for keeping it as is.

@fgdrf fgdrf merged commit ddf5609 into locationtech:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nprigour @fgdrf