Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splits style.advanced into raster and feature bundle #270

Merged
merged 2 commits into from Mar 29, 2018

Conversation

@fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Mar 24, 2018

Main idea is to create seperate bundles for advanced styling to use these side by side and standalone from each other. Asume you have a product that has only support for featuretypes, the customer should not get Raster-Styling pages displayed (the product then would not include style.advanced.raster whereas style.advanced.feature is included (was style.advanced)

  • cleans codebase regading ColorEditors, removes StolenColorEditor
  • moves common usable classes to public packages
  • moves common functionality to style.advanced.core module
  • renames style.advanced to style.advanced.feature

Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net

@fgdrf fgdrf requested a review from jodygarnett Mar 24, 2018
@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 24, 2018

@moovida Are you kind enought to review and comment changes I made? Especially all changes regarding ColorEditors ;)

@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 24, 2018

Relates to #269

fgdrf added 2 commits Mar 23, 2018
* cleans codebase regading ColorEditors, removes StolenColorEditor
* moves common usable classes to public packages
* moves common functionality to style.advanced.core module
* renames style.advanced to style.advanced.feature

Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
@fgdrf fgdrf force-pushed the fgdrf:F_split_up_advanced_style branch from c302f95 to 94e2b8a Mar 29, 2018
@fgdrf fgdrf merged commit a49c86c into locationtech:master Mar 29, 2018
@fgdrf fgdrf added the improvement label Mar 29, 2018
@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 29, 2018
@fgdrf
Copy link
Contributor Author

@fgdrf fgdrf commented Mar 29, 2018

@egouge Again, thank your for testing!

@jodygarnett
Copy link
Contributor

@jodygarnett jodygarnett commented Mar 30, 2018

Thanks @egouge / @fgdrf - just returning to email now, glad frank was not kept waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.