Upgrade eclipse oxygen #275
Conversation
@@ -318,7 +316,8 @@ protected Button createButton(Composite parent, | |||
|
|||
public File findPluginsDir() throws IOException { | |||
Bundle bundle = Platform.getBundle(GEOTOOLS_LIBS_PLUGIN); | |||
String filePath = FileLocator.toFileURL(FileLocator.find(bundle, new Path("gtlib"), emptyMap())).getFile(); | |||
|
|||
String filePath = FileLocator.toFileURL(FileLocator.find(bundle, new Path("glib"), new HashMap<String, String>())).getFile(); |
nprigour
Apr 14, 2018
Contributor
why the path has changed from "gtlib" to "glib"?
why the path has changed from "gtlib" to "glib"?
fgdrf
Apr 14, 2018
Author
Contributor
Good question. Just had a look at the complete class and it looks like it doesn't work anyway. The given bundle defined in GEOTOOLS_LIBS_PLUGIN
doesn't exists anymore, does it?
Good question. Just had a look at the complete class and it looks like it doesn't work anyway. The given bundle defined in GEOTOOLS_LIBS_PLUGIN
doesn't exists anymore, does it?
nprigour
Apr 14, 2018
Contributor
To be honest I have not worked with teradata. The bundle specified by GEOTOOLS_LIBS_PLUGIN seems to be absent
To be honest I have not worked with teradata. The bundle specified by GEOTOOLS_LIBS_PLUGIN seems to be absent
@@ -101,479 +104,5 @@ | |||
<unit id="org.apache.log4j" version="1.2.15.v201012070815"/> | |||
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20140525021250/repository/"/> |
nprigour
Apr 15, 2018
•
Contributor
Maybe it is worth to also update to a newer version of eclipse orbit (applicable to oxygen). Below I provide the needed changes in org.locationtech.udig.target.target:
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="slicer" includeSource="true" type="InstallableUnit">
<unit id="org.apache.batik.dom" version="1.7.1.v201505191845"/>
<unit id="com.google.guava" version="15.0.0.v201403281430"/>
<unit id="org.apache.batik.css" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.transcoder" version="1.7.0.v201011041433"/>
<unit id="org.apache.xerces" version="2.9.0.v201101211617"/>
<unit id="org.easymock" version="2.4.0.v20090202-0900"/>
<unit id="org.hamcrest.library" version="1.3.0.v201505072020"/>
<unit id="org.apache.batik.parser" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.dom.svg" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.ext.awt" version="1.7.0.v201011041433"/>
<unit id="net.miginfocom.layout.swing" version="3.7.1.v200911230030"/>
<unit id="org.hamcrest.core" version="1.3.0.v201303031735"/>
<unit id="org.apache.batik.util" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.util.gui" version="1.7.0.v200903091627"/>
<unit id="org.apache.batik.xml" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.bridge" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.svggen" version="1.7.0.v201011041433"/>
<unit id="net.miginfocom.layout" version="3.7.1.v200911230030"/>
<unit id="net.miginfocom.layout.swt" version="3.7.1.v201505121915"/>
<unit id="com.lowagie.text" version="2.1.7.v201004222200"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="javax.xml" version="1.3.4.v201005080400"/>
<unit id="org.apache.xml.serializer" version="2.7.1.v201005080400"/>
<unit id="org.apache.xml.resolver" version="1.2.0.v201005080400"/>
<unit id="org.apache.commons.logging" version="1.1.1.v201101211721"/>
<unit id="org.apache.log4j" version="1.2.15.v201012070815"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20180330011457/repository/"/>
</location>
Maybe it is worth to also update to a newer version of eclipse orbit (applicable to oxygen). Below I provide the needed changes in org.locationtech.udig.target.target:
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="slicer" includeSource="true" type="InstallableUnit">
<unit id="org.apache.batik.dom" version="1.7.1.v201505191845"/>
<unit id="com.google.guava" version="15.0.0.v201403281430"/>
<unit id="org.apache.batik.css" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.transcoder" version="1.7.0.v201011041433"/>
<unit id="org.apache.xerces" version="2.9.0.v201101211617"/>
<unit id="org.easymock" version="2.4.0.v20090202-0900"/>
<unit id="org.hamcrest.library" version="1.3.0.v201505072020"/>
<unit id="org.apache.batik.parser" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.dom.svg" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.ext.awt" version="1.7.0.v201011041433"/>
<unit id="net.miginfocom.layout.swing" version="3.7.1.v200911230030"/>
<unit id="org.hamcrest.core" version="1.3.0.v201303031735"/>
<unit id="org.apache.batik.util" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.util.gui" version="1.7.0.v200903091627"/>
<unit id="org.apache.batik.xml" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.bridge" version="1.7.0.v201011041433"/>
<unit id="org.apache.batik.svggen" version="1.7.0.v201011041433"/>
<unit id="net.miginfocom.layout" version="3.7.1.v200911230030"/>
<unit id="net.miginfocom.layout.swt" version="3.7.1.v201505121915"/>
<unit id="com.lowagie.text" version="2.1.7.v201004222200"/>
<unit id="org.junit" version="4.12.0.v201504281640"/>
<unit id="javax.xml" version="1.3.4.v201005080400"/>
<unit id="org.apache.xml.serializer" version="2.7.1.v201005080400"/>
<unit id="org.apache.xml.resolver" version="1.2.0.v201005080400"/>
<unit id="org.apache.commons.logging" version="1.1.1.v201101211721"/>
<unit id="org.apache.log4j" version="1.2.15.v201012070815"/>
<repository location="http://download.eclipse.org/tools/orbit/downloads/drops/R20180330011457/repository/"/>
</location>
@nprigour Thanks for this updated regarding orbit installable units. I'll prepare an update! |
Tested local build and if fails with:
It doesn't help to set related Eclipse bugs: |
If I disable macosx.cocoa.x88 environment in root pom, the build is fine
that means we cannot support macosx 32bit environments anymore .. |
The issue with the scale is also on master, so we should fix it independently of this branch. Created issue #276 as bug |
Hi @fgdrf , Yes macosx 32bit is not supported since eclispe mars. |
I thought about implications of an upgrade to oxygen. IMO the resulting product needs a JVM >=1.8 installed. For SDK-Users we should/could still support versions lower than 1.8, e.g. 1.7 because our plugins are still compatible for Eclipse Luna, Mars, Neon, and of cause Oxygen. This implies that the build would compile on 1.7 level (which is untested becaus of lack of support on Jenkins) I‘d like to suggest to enable builds against jdk 1.7 in addition to 1.8 to verify if we are still valid Opinions? |
Hi @fgdrf , |
Adding to my previous comment, using Bundle-RequiredExecutionEnvironment: JavaSE-1.8 for udig plugins and java 1.8 for building does not prohibit use of Eclipse Luna, Mars or Neon as target platforms. The Bundle-RequiredExecutionEnvironment parameter specifies the minimum execution environment. Udig plugins may require Java 1.8 (especially if we intend to upgrade to geotools 19.0) but still use eclipse plugins compiled with an older java version. Backward compatibility is guranteed in java. |
Just sorting: The product we build (against the target file) requires Java 1.8. So it makes sense to think about seperation of concerns: SDK and product. The first should have backward compatibvility which means build with jdk 1.7 and maybe compiled against different target-platformes (mars, neon, oxygen). Conclusion: If we like to use 1.8 features, we need to set Bundle-RequiredExecutionEnvironment: JavaSE-1.8 otherwise its still valid to use Bundle-RequiredExecutionEnvironment: JavaSE-1.7, isn't it? Does this makes sense? |
IMHO the main issue regarding java build version is related to geotools. If we intend to upgrade to a newer version we have to go for java 1.8 even for source code compilation. Geotools 15.x and onward are build with java 1.8 therefore I assume we have to go for a source compatibility level of 1.8 even for the SDK build. |
@nprigour you are absolutely right and therefore we should change it if we
upgrade to latest GeoTools release (on another branch).
Anything else that would block a merge? Feedback from Jenkins build was
fine, no failures for executed tests
Artefacts to test with you can download from build job for pull request 275
https://ci.eclipse.org/udig/job/uDig-PR/lastSuccessfulBuild/
Anyone in position to test on Linux? I‘ll have a look at MacOSX ..
<notifications@github.com> schrieb am Fr. 20. Apr. 2018 um 13:48:
… IMHO the main issue regarding java build version is related to geotools.
If we intend to upgrade to a newer version we have to go for java 1.8 even
for source code compilation. Geotools 15.x and onward are build with java
1.8 therefore I assume we have to go for a source compatibility level of
1.8 even for the SDK build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#275 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnUhf8eNN2czxhLDnsOAGDC8nGYKAgQks5tqcrigaJpZM4TVNgI>
.
|
I deployed the linux 64bit version in ubuntu 14.04, tried to load a couple of maps, perform some selections and edits, create new featureTypes and its seems to run smoothly without any issues |
@nprigour Great, going to test on mac the build and finally the product.. |
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Created following piggy back CQ's for Oribit dependencies:
|
tested on Mac as well. Looks good except a minor problem: the perspective switcher is not available anymore (I assume it disappeared when we swiched to Eclipse E4, see #277) IMHO it isn't a blocker to merge, is it? |
Hi @fgdrf |
@nprigour All CQs I filed yesterday are for the dependencies we resolving from orbit repository. In the past we had other versions (e.g. guave 12.0.0 and junit 4.11). A blocker for now is JAI Dependencies we use to build and at runtime which we cannot ship, if we provide a release under Locationtech umprella. However, we can release right now but cannot provide Artifact downloads from any Eclipse Foundation hosting. Don't get distracted, we move on, merge this branch back and start release train |
CI-Job for merged changes to master finished successfully : https://ci.eclipse.org/udig/job/uDig-master-CI/94/ |
Collaboration with @egouge , @nprigour to upgrade to newer Eclipse release.
For discussion see issue #256