Skip to content

move from get to post #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antoine-lemaitre
Copy link
Contributor

@antoine-lemaitre antoine-lemaitre commented Mar 2, 2021

Hi there!

Get api for oauth/token is deprecated: https://us.forums.blizzard.com/en/blizzard/t/http-get-deprecated-for-oauthtoken-endpoint/15232

I propose those little changes to use the post api.

Bests

@antoine-lemaitre
Copy link
Contributor Author

@lockwooddev I would be very glad if you got time to review it :)

@antoine-lemaitre
Copy link
Contributor Author

@lockwooddev if you are in this area :)

@lockwooddev lockwooddev merged commit 580ff15 into lockwooddev:master May 4, 2021
@antoine-lemaitre
Copy link
Contributor Author

@lockwooddev : thank you! Are you considering making another release in the near future?

@lockwooddev
Copy link
Owner

Sorry for the delays, but life has been busy. I do plan a release, but I first would have to go over all the endpoints to make sure they didn't change everything once again :P
In the meantime I suggest you pip install the specific commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants