Bug when cancelling image upload #374

Closed
pollingj opened this Issue Apr 18, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

pollingj commented Apr 18, 2012

When using something like this

{% editable_file 'Page image', hint: "Upload an image (perfect size: 265px by 192px)", priority: 2 %}{% endeditable_file %}

  1. Click 'change'
  2. Choose new file
  3. Click 'cancel'

The new image gets uploaded even though you've clicked cancel.

Contributor

pollingj commented Apr 18, 2012

I'm assuming the FileView object needs to set the model 'source' attribute back to it's previous value when clicking the cancel button?

did pushed a commit that referenced this issue Apr 20, 2012

@did did closed this Apr 23, 2012

Owner

did commented Apr 23, 2012

test comment

pollingj added a commit to pollingj/engine that referenced this issue Apr 29, 2012

Merge branch 'master' of git://github.com/locomotivecms/engine
* 'master' of git://github.com/locomotivecms/engine: (24 commits)
  date picker was not correctly displayed in the popup form (has_many relationship) + previous form errors remained even within a fresh new popup
  content types can auto-reference them (in a many_to_many relationship for instance)
  performance improvements as described in #383
  improve the upgrade script (wip)
  bump version to 2.0.0.rc7
  new aloha-rails gem (fixing a typo in a css when precompiling it)
  the extends tag was not looking for the right fullpath (when localization is enabled) + sample in order to modify the tinyMCE settings in the back-office
  just a quick test to demonstrate the documentation was wrong (issue #377)
  simple media plugin for Aloha
  issue #321 (current_user) working. url_helpers removed.
  strange error
  strange error
  added current_user
  fix issue #373
  fix issue #374
  repair broken build
  fix issue #367
  fix issue #360
  added missing ru translations for upcoming 2.0 version
  clean the upgrade script (v1 -> v2)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment