Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Nav menu should include content type pages if template is 'listed' #888

Open
Dirklectisch opened this Issue Mar 8, 2014 · 1 comment

Comments

Projects
None yet
2 participants

The navigation menu generated by the nav tag should include content entries when the content-type-template has its listed property set to true. This is necessary because the only other way to include those menu entries is by using a rather dirty hack within a custom menu-entry snippet. See the discussion on the Google Group here:

https://groups.google.com/forum/#!topic/locomotivecms/pFGmRJ_bY5Q

An example use case would be: showing categories defined by a custom content type in the site's global navigation.

I took a quick look at the code for the nav liquid tag to see what this change would entail.

It seems to me that we could change the fetch_entries method to stop filtering out templatized pages but instead replace them with the appropriate content type entries. This would also require updating the render_entry_link method to handle content entries correctly (it currently only handles pages as far as I can tell).

Since I'm brand new to Locomotive and its codebase I would like to know if I am on the right track here. There's probably stuff going on that I'm not aware of yet.

@did did added the feature label Mar 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment