Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Section and Blocks selection have more clickable area #1341

Open
wants to merge 5 commits into
base: master
from

Conversation

@westonganger
Copy link
Contributor

commented Jul 11, 2019

When viewing page section/blocks on Edit Page -> Content tab

  • Current Behaviour:
    • Only clicking on Label of section will enter into it, clicking anywhere else on the section item does nothing
    • Link text becomes underlined (according to the css, this appeared to be an unintended bug)
  • New Behaviour:
    • Clicking on anything except the drag handle will enter into the section
    • Link text no longer underlines as intended.

Note: I would have wrapped the whole div in a the link component however this led to mouse up/dragging issues in firefox. To workaround this I simply wrapper the image/icon and label tags with the relevant link component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.