Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Array Liquid filters: `push`, `pop`, `unshift`, `shift` #143

Merged

Conversation

@westonganger
Copy link
Contributor

commented Jun 5, 2019

@did did merged commit 9900c7d into locomotivecms:master Jun 22, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

did added a commit that referenced this pull request Jun 22, 2019

@did

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

thanks @westonganger! Just a little comment, usually, I only accept PR with tests. Nothing major but your PR broke our tests suite (I don't understand why Github did not complain about it, weird).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.