Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console.log calls #370

Open
wants to merge 1 commit into
base: master
from

Conversation

@westonganger
Copy link
Contributor

commented May 28, 2019

No description provided.

@did

This comment has been minimized.

Copy link
Member

commented May 29, 2019

instead of removing them, why not commenting them once generated? Free to the developers to uncomment them. Any thoughts @westonganger and @manuchap?

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

I would prefer either:

A. commented out by default
B. wrap them in an if(!production) call

@manuchap

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Sry, I removed my previous comment which was irrelevant/unclear (which happens often 🙃).
The if(!production) option seems legit.
I was just afraid to see them disappear since I've limited coding skill and to me every log is a good log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.