From 4089b6cc3370f91d3648edad5893ffecdaa35df8 Mon Sep 17 00:00:00 2001 From: Bence Magyar Date: Wed, 12 Nov 2025 19:25:50 +0000 Subject: [PATCH 1/2] cancel timer in destructor --- orbbec_camera/src/ob_camera_node.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/orbbec_camera/src/ob_camera_node.cpp b/orbbec_camera/src/ob_camera_node.cpp index 13669378..89297876 100644 --- a/orbbec_camera/src/ob_camera_node.cpp +++ b/orbbec_camera/src/ob_camera_node.cpp @@ -94,7 +94,10 @@ void OBCameraNode::setAndGetNodeParameter( } } -OBCameraNode::~OBCameraNode() noexcept { clean(); } +OBCameraNode::~OBCameraNode() noexcept { + diagnostic_timer_->cancel(); + clean(); + } void OBCameraNode::rebootDevice() { RCLCPP_WARN_STREAM(logger_, "Reboot device"); From 410d05f378fdb1c17d0ff925fc3ff7e75f010586 Mon Sep 17 00:00:00 2001 From: Bence Magyar Date: Wed, 12 Nov 2025 23:38:32 +0000 Subject: [PATCH 2/2] Update ob_camera_node.cpp --- orbbec_camera/src/ob_camera_node.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/orbbec_camera/src/ob_camera_node.cpp b/orbbec_camera/src/ob_camera_node.cpp index 89297876..60a86b1c 100644 --- a/orbbec_camera/src/ob_camera_node.cpp +++ b/orbbec_camera/src/ob_camera_node.cpp @@ -95,7 +95,9 @@ void OBCameraNode::setAndGetNodeParameter( } OBCameraNode::~OBCameraNode() noexcept { - diagnostic_timer_->cancel(); + if(diagnostic_timer_) { + diagnostic_timer_->cancel(); + } clean(); }