Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass arguments to internal venv module #36

Merged
merged 1 commit into from Mar 6, 2019
Merged

Pass arguments to internal venv module #36

merged 1 commit into from Mar 6, 2019

Conversation

@paulbovbel
Copy link
Member

paulbovbel commented Mar 6, 2019

Passing arguments to internal venv module was broken, causing defaults to be used at all times.

@paulbovbel paulbovbel requested a review from ablakey Mar 6, 2019
@ablakey
ablakey approved these changes Mar 6, 2019
@paulbovbel

This comment has been minimized.

Copy link
Member Author

paulbovbel commented Mar 6, 2019

The build failures on jenkins are something else, I think it's due to the path-munging behind done by catkin_virtualenv and the insanely long paths in jenkins. Going to have to sort that out at some point...

@paulbovbel paulbovbel merged commit 3aef0cc into devel Mar 6, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/branch This commit cannot be built
Details
Hpr__catkin_virtualenv__ubuntu_xenial_amd64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paulbovbel paulbovbel deleted the fix-args branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.