Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3 isolated builds #37

Merged
merged 8 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@paulbovbel
Copy link
Member

commented Mar 7, 2019

  • Pull in an upstream fix to deal with new shebang styles
  • add a new test for isolated py3 virtualenvs
  • switch to using an internal pip module

@paulbovbel paulbovbel changed the title Disable system site packaes Fix py3 test Mar 7, 2019

paulbovbel added some commits Mar 7, 2019

@paulbovbel paulbovbel changed the title Fix py3 test Fix python3 isolated builds Mar 7, 2019

@paulbovbel paulbovbel requested a review from ablakey Mar 7, 2019

@paulbovbel paulbovbel marked this pull request as ready for review Mar 7, 2019

@paulbovbel

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Tests should pass once the new version of ros/ros makes it into the build

@ablakey

ablakey approved these changes Mar 7, 2019

@paulbovbel paulbovbel merged commit 98da8a5 into devel Mar 7, 2019

1 of 3 checks passed

Hpr__catkin_virtualenv__ubuntu_xenial_amd64 Build finished.
Details
continuous-integration/jenkins/branch This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paulbovbel paulbovbel deleted the py3-tests branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.